[PATCH] D57504: RFC: Prototype & Roadmap for vector predication in LLVM
Simon Moll via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 30 02:12:35 PDT 2019
simoll marked 8 inline comments as done.
simoll added a comment.
In D57504#1726007 <https://reviews.llvm.org/D57504#1726007>, @SjoerdMeijer wrote:
> Hi Simon, I went through the code for the first time, and this is a first round of proper nitpicks from my side. Please ignore if you want to focus on the bigger picture at this point in the discussion, but these are just some things I noticed. General nitpick is that you should run clang-format as there are quite a few coding style issues: indentation, indentation of arguments, exceeding 80 columns, placement of `*` and `&` in arguments and return values, etc. And find some more nitpicks inlined.
Hi Sjoerd, thanks for you comments! i've fixed the inline nitpicks right away. I'll do a style pass for the actual commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57504/new/
https://reviews.llvm.org/D57504
More information about the llvm-commits
mailing list