[PATCH] D68819: [Utils] Allow update_test_checks to check function arguments

Fri Nov 1 13:09:23 PDT 2019

spatel added a comment.

In D68819#1730310 <https://reviews.llvm.org/D68819#1730310>, @jdoerfert wrote:

> In D68819#1730164 <https://reviews.llvm.org/D68819#1730164>, @spatel wrote:
>
> > Here's a current example of the trade-off:
> >  D59710 <https://reviews.llvm.org/D59710>
> >
> > I agree that adding the 'define...' glob to the label check is an improvement, but at the same time, many of us use the scripts almost exclusively on single function regression tests (no calls)...which is probably why we never encountered the motivating problem for this change.
> >
> > As I understand it, there's currently no way to disable the 'define' glob. So I either have the burden of doing separate pre-commits to update hundreds of test files or ask reviewers to look past that noise. We want to push people towards the better future, but it would be more friendly to offer this feature with an opt-out. That is, default to the new way, but let people disable the 'define' generation to update on their own terms/as needed.
>
>
> The combination of D69701 <https://reviews.llvm.org/D69701> and D69719 <https://reviews.llvm.org/D69719> will remove the unwanted effects but allow proper support in the future. If we get them in before your commit the churn goes away.

Thanks! I haven't followed all of the script patches, but things are quiet once again in the files that I've updated just now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68819/new/

https://reviews.llvm.org/D68819