[PATCH] D68850: [Utils] Deal with occasionally deleted functions

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 14:50:41 PDT 2019


jdoerfert added a comment.

The difference is when we run `update_test_checks.py` on the following code

  ; RUN: opt -S < %s | FileCheck %s --check-prefixes=ALL,FIRST
  ; RUN: opt -S -globalopt < %s | FileCheck %s --check-prefixes=ALL,SECOND
  
  define internal void @f() {
    ret void
  }

we will see

  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
  ; RUN: opt -S < %s | FileCheck %s --check-prefixes=ALL,FIRST
  ; RUN: opt -S -globalopt < %s | FileCheck %s --check-prefixes=ALL,SECOND
  
  define internal void @f() {
  ; FIRST-LABEL: define {{[^@]+}}@f(
  ; FIRST-NEXT:    ret void
  ;
    ret void
  }

and not

  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
  ; RUN: opt -S < %s | FileCheck %s --check-prefixes=ALL,FIRST
  ; RUN: opt -S -globalopt < %s | FileCheck %s --check-prefixes=ALL,SECOND
  
  define internal void @f() {
  ; ALL-LABEL: @f(
  ; ALL-NEXT:    ret void
  ;
    ret void
  }
  
  
  ---
  
  ping


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68850/new/

https://reviews.llvm.org/D68850





More information about the llvm-commits mailing list