[PATCH] D59710: [SLP] remove lower limit for forming reduction patterns

Fri Nov 1 05:15:18 PDT 2019

spatel marked an inline comment as done.
spatel added inline comments.

================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/reorder_repeated_ops.ll:49
+; CHECK-NEXT:    [[TMP10:%.*]] = icmp slt i32 undef, [[TMP37]]
+; CHECK-NEXT:    [[TMP11:%.*]] = select i1 [[TMP10]], i32 undef, i32 [[TMP37]]
+; CHECK-NEXT:    [[TMP12:%.*]] = icmp slt i32 [[TMP11]], undef
----------------
RKSimon wrote:
> Isn't [[TMP11:%.*]] already defined at line 22?
Yes - update_test_checks.py has a bug with input IR that contains explicit "%tmp##" names for values. Those conflict with the script's naming that uses "TMP##" for regex matching of unnamed values. It's only by chance/luck that this test is passing even without this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59710/new/

https://reviews.llvm.org/D59710