[PATCH] D69669: [NFC][llvm-readobj] Pull common code into a helper

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5448
+  StringRef SectionName;
+  this->dumper()->getSectionNameIndex(Symbol, First, SectionName, SectionIndex);
+  W.printHex("Section", SectionName, SectionIndex);
----------------
jhenderson wrote:
> grimar wrote:
> > To make the change above, this method and methods inside should be changed.
> I'm changing the `getSectionNameIndex` method in D69670 to split it up. Is that what you're referring to? Once that change lands, it might be possible to change the Object library `getExtendedSymbolTableIndex` interface to take an index, or I could change the new `getSymbolSectionIndex` function to figure out the value of `First` instead of passing it in.
> I'm changing the getSectionNameIndex method in D69670 to split it up. Is that what you're referring to?
No, I did not see D69670 when reviewed this one, but anyways I meant this and `getExtendedSymbolTableIndex` and may be something else will need a change to take an index if we deside to get rid of 'First'.

I think you can land your set of patches first and we can refactor this piece after that, as it is independent and unrelated actually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69669/new/

https://reviews.llvm.org/D69669