[PATCH] D69669: [NFC][llvm-readobj] Pull common code into a helper

Fri Nov 1 03:05:09 PDT 2019

jhenderson marked an inline comment as done.
jhenderson added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5448
+  StringRef SectionName;
+  this->dumper()->getSectionNameIndex(Symbol, First, SectionName, SectionIndex);
+  W.printHex("Section", SectionName, SectionIndex);
----------------
grimar wrote:
> To make the change above, this method and methods inside should be changed.
I'm changing the `getSectionNameIndex` method in D69670 to split it up. Is that what you're referring to? Once that change lands, it might be possible to change the Object library `getExtendedSymbolTableIndex` interface to take an index, or I could change the new `getSymbolSectionIndex` function to figure out the value of `First` instead of passing it in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69669/new/

https://reviews.llvm.org/D69669