[PATCH] D69681: gn build: Add support for cross-compiling the builtins and profile runtimes for Android aarch64 and arm.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn:372
+
+      current_cpu_is_vfp = current_cpu == "arm" && current_os == "android"
+      if (current_cpu_is_vfp) {
----------------
phosek wrote:
> Is `current_cpu_is_vfp` used anywhere else? If not I'd just inline it.
Yeah, I wasn't sure whether inlining it would be clear enough but maybe the `vfp` substring in the names of all the files below is enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69681/new/

https://reviews.llvm.org/D69681