[PATCH] D69681: gn build: Add support for cross-compiling the builtins and profile runtimes for Android aarch64 and arm.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 15:02:29 PDT 2019


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn:372
+
+      current_cpu_is_vfp = current_cpu == "arm" && current_os == "android"
+      if (current_cpu_is_vfp) {
----------------
Is `current_cpu_is_vfp` used anywhere else? If not I'd just inline it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69681/new/

https://reviews.llvm.org/D69681





More information about the llvm-commits mailing list