[PATCH] D68708: [RFC] Adopt Dexter and use it to run debuginfo-tests

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 15:28:29 PDT 2019


Hi,

On Thu, Oct 31, 2019 at 8:57 PM Greg Bedwell via Phabricator
<reviews at reviews.llvm.org> wrote:
> I suspect what we're seeing is that something earlier in the command line is being consumed as a positional argument, then we get some `--optional` arguments and so it's unhappy to see further positional arguments later on.  E.g.

*facepalm* -- I made the "%dexter" substitution expand to "python3
dexter.py test --some-options" so that I could configure more
test-mode options at cmake time. That means that all those feature
tests won't work because they're expanding to command lines like
"dexter.py test help", which aren't legitimate.

Should be an easy fix tomorrow (add a %dexter_test substitution
instead). I imagine the reason I didn't catch this was through running
llvm-lit over the dexter-tests directory, rather than running "ninja
check-debuginfo" directly, sorry.

--
Thanks,
Jeremy


More information about the llvm-commits mailing list