[PATCH] D68708: [RFC] Adopt Dexter and use it to run debuginfo-tests

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell added a comment.

(quoting Jeremy's on-list reply)

> Hi,
> 
> I'm having auth issues with phab and google accounts right now, so
>  can't reply on phab,
> 
> Thanks for pushing through the python 3 issues!,
> 
> On Thu, Oct 31, 2019 at 6:28 PM Adrian Prantl via Phabricator
>  <reviews at reviews.llvm.org> wrote:
>  > I don't have time to investigate this right now so I XFAILed the tests on Darwin in 8e406204418895f7b09d1a9a3f8037e741a43968 <https://reviews.llvm.org/rG8e406204418895f7b09d1a9a3f8037e741a43968> https://reviews.llvm.org/rG8e406204418895f7b09d1a9a3f8037e741a43968. Perhaps the solution is obvious to you, let me know if it isn't, it would be great to revert the XFAILs again!
> 
> Exciting -- it's just argparse plus a wrapper, and we've been using
>  python 3.6 so I wouldn't expect python 3.7 to regress. The "--" is the
>  positional-argument separator (bottom of the section in [0])
>  indicating that everything following is a positional argument.
> 
> Technically all those '--' separators can be deleted as we're not
>  doing anything advanced with command lines. It's odd that this proves
>  to be an incompatibility though.
> 
> [0] https://docs.python.org/dev/library/argparse.html#arguments-containing
> 
> - Thanks, Jeremy

I suspect what we're seeing is that something earlier in the command line is being consumed as a positional argument, then we get some `--optional` arguments and so it's unhappy to see further positional arguments later on.  E.g.

  $ type 1.py
  import argparse
  parser = argparse.ArgumentParser()
  parser.add_argument('positional', nargs='+')
  parser.add_argument('--optional', action='store_true')
  parser.parse_args()
  
  $ py -3.6 1.py pos1 pos2 --optional -- pos3
  usage: 1.py [-h] [--optional] positional [positional ...]
  1.py: error: unrecognized arguments: -- pos3
  
  $

Hopefully we should be able to figure out what's going on tomorrow.  If worst comes to worst we can temporarily add a bit of logging to the error message easily enough that should shed some light.

Thanks for your help on this!

-Greg


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68708/new/

https://reviews.llvm.org/D68708