[PATCH] D68819: [Utils] Allow update_test_checks to check function arguments

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D68819#1729354 <https://reviews.llvm.org/D68819#1729354>, @nikic wrote:

> Ugh, I now see that this is actually intentional. I think any changes to the default behavior of update_tests_checks should be discussed on llvm-dev in the future. These kinds of changes are quite disruptive and in this case imho don't pay for themselves.


+1

I even asked about this:

In D68819#1704550 <https://reviews.llvm.org/D68819#1704550>, @jdoerfert wrote:

> In D68819#1704491 <https://reviews.llvm.org/D68819#1704491>, @lebedev.ri wrote:
>
> > This doesn't change the default, right?
>
>
> It shouldn't no. I tested it on some formatted files but I'm unsure if there are other interactions I don't know about.


And was under impression that it was still the case as per

In D68819#1706251 <https://reviews.llvm.org/D68819#1706251>, @jdoerfert wrote:

> In D68819#1705424 <https://reviews.llvm.org/D68819#1705424>, @greened wrote:
>
> > In D68819#1704962 <https://reviews.llvm.org/D68819#1704962>, @jdoerfert wrote:
> >
> > > We can, or should, combine D68153 <https://reviews.llvm.org/D68153> and this, either in one or two patches.
> >
> >
> > Sounds good.  Do you think D68153 <https://reviews.llvm.org/D68153> should operate under the `--function-signature` flag, under a different flag or always include `define` in the pattern (meaning all tests will change when the tool is re-run)?
>
>
> I think D68153 <https://reviews.llvm.org/D68153> is a small enough change and at the same time helpful enough to run it always. Adding function signature is not for everyone so I added the flag. I can put it under the flag if people think it should live there though.


@jdoerfert is this really fully intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68819/new/

https://reviews.llvm.org/D68819