[PATCH] D68819: [Utils] Allow update_test_checks to check function arguments

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D68819#1729354 <https://reviews.llvm.org/D68819#1729354>, @nikic wrote:

> Ugh, I now see that this is actually intentional. I think any changes to the default behavior of update_tests_checks should be discussed on llvm-dev in the future. These kinds of changes are quite disruptive and in this case imho don't pay for themselves.


It prevents us from accidentally matching the wrong thing, see D68153 <https://reviews.llvm.org/D68153>. We can (now), if we really want to, put that change under the flag as well. I really don't think it should be under a flag. While I see the cost of having new `define {{[^@]+}}` in upcoming diffs, it will actually improve the match quality. Now if that is worth it is obviously up for debate.

FWIW, D68850 <https://reviews.llvm.org/D68850> will also change "the default" but only if the default would not have allowed to use the test script in the first place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68819/new/

https://reviews.llvm.org/D68819