[PATCH] D68757: [X86] Add strict fp support for instructions fadd/fsub/fmul/fdiv

[Pengfei Wang via Phabricator via llvm-commits]

pengfei marked an inline comment as done.
pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:746
+                   MVT::f64, MVT::v2f64, MVT::v4f64, MVT::v8f64 }) {
+    setOperationAction(ISD::STRICT_FADD, VT, Legal);
+    setOperationAction(ISD::STRICT_FSUB, VT, Legal);
----------------
craig.topper wrote:
> If SSE isn't enabled, isn't this broken for f32. Similar for SSE2 and f64?
I don't think it will break X87 types, but it does seems to be weird that legalize X87 strict nodes at the same time before X87 patches.
I'd like to commit this patch after D68857 and remove the common code in that patch. And it's probable, because I need to model AVX instructions before commiting this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68757/new/

https://reviews.llvm.org/D68757