[PATCH] D69610: Fix compiler-rt build on macOS without XCode

[Dan Liew via Phabricator via llvm-commits]

delcypher requested changes to this revision.
delcypher added inline comments.
This revision now requires changes to proceed.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:10
 # the current Xcode.
 function(find_darwin_sdk_dir var sdk_name)
   set(DARWIN_${sdk_name}_CACHED_SYSROOT "" CACHE STRING "Darwin SDK path for SDK ${sdk_name}.")
----------------
yln wrote:
> Would this function benefit from a similar change?
Yes we should but perhaps as a separate patch?


================
Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:52
     execute_process(
       COMMAND xcodebuild -version -sdk ${sdk_name}.internal SDKVersion
       RESULT_VARIABLE result_process
----------------
I would just replace all the `xcodebuild` commands in `find_darwin_sdk_version` with `xcrun --sdk ${sdk_name} --show-sdk-version`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69610/new/

https://reviews.llvm.org/D69610