[PATCH] D69610: Fix compiler-rt build on macOS without XCode

[Julian Lettner via Phabricator via llvm-commits]

yln added a comment.

@delcypher: would `xcrun --sdk ${sdk_name} --show-sdk-version` work in all cases? If yes, we could use it instead of `xcodebuild`.

LGTM otherwise.



================
Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:10
 # the current Xcode.
 function(find_darwin_sdk_dir var sdk_name)
   set(DARWIN_${sdk_name}_CACHED_SYSROOT "" CACHE STRING "Darwin SDK path for SDK ${sdk_name}.")
----------------
Would this function benefit from a similar change?


================
Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:71
+    execute_process(
+            COMMAND  xcrun --sdk ${sdk_name} --show-sdk-version
+            RESULT_VARIABLE result_process
----------------
Nitpick: indent not consistent with other occurences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69610/new/

https://reviews.llvm.org/D69610