[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 14:52:46 PDT 2019


lhames added subscribers: beanz, lhames.
lhames added a comment.

In D69356#1726074 <https://reviews.llvm.org/D69356#1726074>, @beanz wrote:

> ... It seems to me that maybe a more appropriate approach is that `LLVM_SUPPORT_PLUGINS` implies `LLVM_NO_DEAD_STRIP`, rather than conflating the two options.


Yep — there are use-cases for no-dead-strip that aren’t plugins. I’m not sure this rename helps. I think the .*PLUGINS.* options need more consideration, and that LLVM_NO_DEAD_STRIP should be reinstated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69356/new/

https://reviews.llvm.org/D69356





More information about the llvm-commits mailing list