[PATCH] D68712: Avoid PT_LOAD to have overlapping p_offset ranges on EM_AMDGPU

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 26 13:39:18 PDT 2019


MaskRay added a comment.

In D68712#1722274 <https://reviews.llvm.org/D68712#1722274>, @bcain wrote:

> Is this a permanent constraint for AMDGPU or just a temporary workaround?  If the latter, it's best to annotate that's the case.
>
> If it is a permanent constraint, can it be described as a quality of the target instead of a guard based on a specific target?


@dineshkb-amd does not respond. My understanding is that AMD has one or a few tests that rely on the non-overlapping p_offset property. I think @dineshkb-amd should just work around that particular test and don't change lld code at all.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68712/new/

https://reviews.llvm.org/D68712





More information about the llvm-commits mailing list