[PATCH] D68712: Avoid PT_LOAD to have overlapping p_offset ranges on EM_AMDGPU

[Brian Cain via Phabricator via llvm-commits]

bcain added a comment.

Is this a permanent constraint for AMDGPU or just a temporary workaround?  If the latter, it's best to annotate that's the case.

If it is a permanent constraint, can it be described as a quality of the target instead of a guard based on a specific target?



================
Comment at: ELF/Writer.cpp:2244
       // previous segment anyway.
-      if (config->zSeparate == SeparateSegmentKind::Loadable ||
+      bool enable = config->emachine != EM_AMDGPU;
+
----------------
This identifier name is clearer if it's more explicit about the meaning.  e.g. `EnableAlignment`, `EnableAddrExpr` or `TargetMachineSupportsAlignment`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68712/new/

https://reviews.llvm.org/D68712