[PATCH] D69003: [dsymutil] Add ${system_libs} to target link libraries

Gokturk Yuksek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 25 15:15:35 PDT 2019


gokturk updated this revision to Diff 226505.
gokturk added a comment.

I'm updating the patch for completeness. `system_libs` doesn't propagate, so I had to get the system libs property of Support in dsymutil:

  get_property(system_libs TARGET LLVMSupport PROPERTY LLVM_SYSTEM_LIBS)

I understand that there is already an objection to this but like I said, I'm updating it for completeness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69003/new/

https://reviews.llvm.org/D69003

Files:
  llvm/tools/dsymutil/CMakeLists.txt


Index: llvm/tools/dsymutil/CMakeLists.txt
===================================================================
--- llvm/tools/dsymutil/CMakeLists.txt
+++ llvm/tools/dsymutil/CMakeLists.txt
@@ -38,3 +38,6 @@
 if(APPLE)
   target_link_libraries(dsymutil PRIVATE "-framework CoreFoundation")
 endif(APPLE)
+
+get_property(system_libs TARGET LLVMSupport PROPERTY LLVM_SYSTEM_LIBS)
+target_link_libraries(dsymutil PRIVATE ${system_libs})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69003.226505.patch
Type: text/x-patch
Size: 432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191025/b7bb5afe/attachment.bin>


More information about the llvm-commits mailing list