[PATCH] D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

Hi, I am not familiar with this code but seeing as you're not getting reviews and this seems like a serious problem, I am willing to take a look (and maybe if I say something wrong here, Cunningham's Law will save us).

Without looking at the code too deeply, I am wondering about the testcase.  Per the commit message it sounds like you're saying that invalid LLVM IR is generated.  If so, can we have an LLVM IR testcase that runs this specific pass, rather than an llc testcase?  Based on what's in the commit message, it sounds like such a testcase would be far simpler (and indeed less fragile) than what we have here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65967/new/

https://reviews.llvm.org/D65967