[llvm] a6b0219 - Revert "[ARM] Uses "Sun Style" syntax for section switching"

[Eric Christopher via llvm-commits]

Please try to say why next time you revert so that it's more clear.

On Fri, Oct 25, 2019 at 2:03 PM Jian Cai via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Jian Cai
> Date: 2019-10-25T14:03:07-07:00
> New Revision: a6b0219fc4a78e96ff268d101b911466dedbbf2c
>
> URL: https://github.com/llvm/llvm-project/commit/a6b0219fc4a78e96ff268d101b911466dedbbf2c
> DIFF: https://github.com/llvm/llvm-project/commit/a6b0219fc4a78e96ff268d101b911466dedbbf2c.diff
>
> LOG: Revert "[ARM] Uses "Sun Style" syntax for section switching"
>
> This reverts commit 03de2f84fc4acf06c719cd007b5459c9d4d0a20c.
>
> Added:
>
>
> Modified:
>     llvm/include/llvm/MC/MCAsmInfo.h
>     llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
>
> Removed:
>     llvm/test/MC/AsmParser/gas-compl-sun-elf.s
>
>
> ################################################################################
> diff  --git a/llvm/include/llvm/MC/MCAsmInfo.h b/llvm/include/llvm/MC/MCAsmInfo.h
> index ce24ffb9744d..3261c483e0d8 100644
> --- a/llvm/include/llvm/MC/MCAsmInfo.h
> +++ b/llvm/include/llvm/MC/MCAsmInfo.h
> @@ -215,7 +215,7 @@ class MCAsmInfo {
>    const char *TPRel64Directive = nullptr;
>
>    /// This is true if this target uses "Sun Style" syntax for section switching
> -  /// ("#alloc,#write" etc) alongside the normal ELF syntax (,"a,w") in
> +  /// ("#alloc,#write" etc) instead of the normal ELF syntax (,"a,w") in
>    /// .section directives.  Defaults to false.
>    bool SunStyleELFSectionSwitchSyntax = false;
>
>
> diff  --git a/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp b/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
> index 03505c0876aa..d30d15df3d00 100644
> --- a/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
> +++ b/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
> @@ -75,10 +75,6 @@ ARMELFMCAsmInfo::ARMELFMCAsmInfo(const Triple &TheTriple) {
>    UseParensForSymbolVariant = true;
>
>    UseIntegratedAssembler = true;
> -
> -  // The GNU assembler supports Sun style section switching for Arm targets, and
> -  // it is used in projects like the Linux kernel.
> -  SunStyleELFSectionSwitchSyntax = true;
>  }
>
>  void ARMELFMCAsmInfo::setUseIntegratedAssembler(bool Value) {
>
> diff  --git a/llvm/test/MC/AsmParser/gas-compl-sun-elf.s b/llvm/test/MC/AsmParser/gas-compl-sun-elf.s
> deleted file mode 100644
> index 7934109d3432..000000000000
> --- a/llvm/test/MC/AsmParser/gas-compl-sun-elf.s
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -@ RUN: llvm-mc -filetype=obj -triple arm-linux-gnu %s -o - | llvm-readelf --sections | FileCheck %s
> -
> -@ CHECK: .f1              PROGBITS        00000000 000034 000000 00   A  0   0  1
> -.section ".f1", #alloc
> -
> -@ CHECK: .f2              PROGBITS        00000000 000034 000000 00   W  0   0  1
> -.section ".f2", #write
> -
> -@ CHECK: .f3              PROGBITS        00000000 000034 000000 00   A  0   0  1
> -.section ".f3", "a"
> -
> -@ CHECK: .f4              PROGBITS        00000000 000034 000000 00   W  0   0  1
> -.section ".f4", "w"
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits