[PATCH] D69449: TableGen: Use enum names in composeSubRegIndices table
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 25 14:10:58 PDT 2019
arsenm created this revision.
arsenm added reviewers: qcolombet, MatzeB.
Herald added a subscriber: wdng.
Herald added a project: LLVM.
I'm not sure why this is using the raw enum value. This makes reading the generated table comprehensible.
https://reviews.llvm.org/D69449
Files:
llvm/utils/TableGen/RegisterInfoEmitter.cpp
Index: llvm/utils/TableGen/RegisterInfoEmitter.cpp
===================================================================
--- llvm/utils/TableGen/RegisterInfoEmitter.cpp
+++ llvm/utils/TableGen/RegisterInfoEmitter.cpp
@@ -742,7 +742,7 @@
OS << " { ";
for (unsigned i = 0, e = SubRegIndicesSize; i != e; ++i)
if (Rows[r][i])
- OS << Rows[r][i]->EnumValue << ", ";
+ OS << Rows[r][i]->getQualifiedName() << ", ";
else
OS << "0, ";
OS << "},\n";
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69449.226499.patch
Type: text/x-patch
Size: 495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191025/91b1ab41/attachment.bin>
More information about the llvm-commits
mailing list