[PATCH] D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D69188#1716472 <https://reviews.llvm.org/D69188#1716472>, @thieta wrote:

> @rupprecht thanks for the review - happy to address your comments and change the commit message and inline comment to reflect my findings above if you guys decide to accept this approach. I think this needs to be documented if nothing else considering how confusing the error on device actually is.


I'm good with the approach in this patch -- once the test/docs changes are done, I'll accept it. I also ran into Jake yesterday at the llvm devmtg and came to the same conclusion. (Also, sorry for the delay, which was also because of the devmtg). `--strip-all` should generally be more aggressive, but not so much that it totally doesn't work as a default mode on common platforms.

Also, do you have commit access (or plan on getting it), or would you like one of us to commit it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69188/new/

https://reviews.llvm.org/D69188