[PATCH] D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files

Mon Oct 21 20:59:56 PDT 2019

thieta marked an inline comment as done.
thieta added inline comments.

================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:506
         return false;
+      // While keeping this section around shouldn't be needed
+      // there are older version of glibc and eglibc that requires
----------------
MaskRay wrote:
> We should document the upstream glibc bug (as an example, put a link `http://sourceware.org/PR16773`) and the first version of glibc that fixed the bug, so that we can retire the exemption at some point (I think we usually don't care about toolchains that are more than 5 years old).
Unfortunately this bug is not in upstream glibc but rather in the patchset that ubuntu/debian uses. There has been no upstream fix as far as I can tell and the bug hasn't been updated since 2017: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1712938

I added a little info to that bug now to hope to see someone review it again.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69188/new/

https://reviews.llvm.org/D69188