[PATCH] D65506: [MachineScheduler] improve reuse of 'releaseNode'method

Lorenzo Casalino via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 09:23:08 PDT 2019


DoktorC added a comment.

Hi @fhahn ,
sorry for the long silence period.

I tracked down the problem: it is how the `Pending` queue is explored with this patch (from the end).
Clearly, this affects which nodes move first from pending to available state; this is critical when
the `Available` queue reaches the maximum size.

I can re-write the queue exploration to match the pre-patch behaviour.
However, I'm wondering if it is a sign of "bad" design: shouldn't the pending queue explore the best
candidates to move in the available queue?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65506/new/

https://reviews.llvm.org/D65506





More information about the llvm-commits mailing list