[PATCH] D69004: Use portable flag with nm in extract_symbols.py

[David Tenty via Phabricator via llvm-commits]

daltenty marked 2 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/utils/extract_symbols.py:51
         # Look for external symbols that are defined in some section
-        match = re.match("^\S+\s+[BDGRSTVW]\s+(\S+)$", line)
+        match = re.match("^(\S+)\s+[BDGRSTVW]\s+\S+\s+\S+$", line)
         if match:
----------------
stevewan wrote:
> So I see we are changing the target of group in the regex match, but I don't see clearly the rationale behind it. Is it based on some testing outputs?
The nm portable output format is:  
    "%s%s %s %x %x\n", 
    <library/object name>, <name>, <type>, <value>, <size> 

(where <library/object name> will be empty in our usage)

So we change the target group to deal with the new position of the symbol name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69004/new/

https://reviews.llvm.org/D69004