[PATCH] D69004: Use portable flag with nm in extract_symbols.py
Steven Wan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 23 12:06:23 PDT 2019
stevewan added inline comments.
================
Comment at: llvm/utils/extract_symbols.py:51
# Look for external symbols that are defined in some section
- match = re.match("^\S+\s+[BDGRSTVW]\s+(\S+)$", line)
+ match = re.match("^(\S+)\s+[BDGRSTVW]\s+\S+\s+\S+$", line)
if match:
----------------
So I see we are changing the target of group in the regex match, but I don't see clearly the rationale behind it. Is it based on some testing outputs?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69004/new/
https://reviews.llvm.org/D69004
More information about the llvm-commits
mailing list