[PATCH] D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI.

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6818
+  const unsigned MinParameterSaveAreaSize = 8 * PtrByteSize;
+  const unsigned NumBytes = LinkageSize + MinParameterSaveAreaSize;
 
----------------
cebowleratibm wrote:
> sfertile wrote:
> > You should be taking the max between `LinkageSize + MinParameterSaveAreaSize` and the stack size determined by the CCState object.
> Agreed but the patch is meant to be NFCI and the current code doesn't support arguments on the stack so this has the same semantics as the prior code.  A future patch will address your concern.
But `CC_AIX`  also doesn't handle arguments on the stack so IIUC the largest offset you could get back is ` LinkageSize + MinParameterSaveAreaSize` keeping this patch NFC. 

FWIW I am OK with you leaving it out for now, I don't think its worth holding up the patch over. We should have a lit tests that tests overflow args though that shows the error.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6705
+
+  if (ArgFlags.isByVal())
+    report_fatal_error("Passing structure by value is unimplemented.");
----------------
We should probably have some simple lit tests for these fatal errors. At least byval/sret/nest. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69101/new/

https://reviews.llvm.org/D69101