[PATCH] D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI.

Chris Bowler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 04:57:12 PDT 2019


cebowleratibm marked 2 inline comments as done.
cebowleratibm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6818
+  const unsigned MinParameterSaveAreaSize = 8 * PtrByteSize;
+  const unsigned NumBytes = LinkageSize + MinParameterSaveAreaSize;
 
----------------
sfertile wrote:
> You should be taking the max between `LinkageSize + MinParameterSaveAreaSize` and the stack size determined by the CCState object.
Agreed but the patch is meant to be NFCI and the current code doesn't support arguments on the stack so this has the same semantics as the prior code.  A future patch will address your concern.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69101/new/

https://reviews.llvm.org/D69101





More information about the llvm-commits mailing list