[PATCH] D52431: [PowerPC] Turn on CR-Logical reducer pass

Sat Oct 19 11:58:49 PDT 2019

nemanjai updated this revision to Diff 225762.
nemanjai added a comment.

A few updates to the CR Logical Reducer in addition to the pulled patch that turns it on:

- Do not use `std::vector` as there is no real reason for it
- Do not take references into a growable data structure :(

@RKSimon Simon, could you do me a big favour and try this out on the machine on which you saw the failures. I am not sure if this is the (only) issue but references into a growable data structure certainly should be removed. Thanks for spotting this issue - I don't know what I was thinking when I originally wrote this a long time ago.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52431/new/

https://reviews.llvm.org/D52431

Files:
  lib/Target/PowerPC/PPCReduceCRLogicals.cpp
  lib/Target/PowerPC/PPCTargetMachine.cpp
  test/CodeGen/PowerPC/2008-10-28-f128-i32.ll
  test/CodeGen/PowerPC/brcond.ll
  test/CodeGen/PowerPC/pr42492.ll
  test/CodeGen/PowerPC/tocSaveInPrologue.ll
  test/CodeGen/PowerPC/vec-min-max.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52431.225762.patch
Type: text/x-patch
Size: 9772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191019/6a6eebe1/attachment.bin>