[PATCH] D52431: [PowerPC] Turn on CR-Logical reducer pass

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 19 08:59:00 PDT 2019


nemanjai added a comment.

In D52431#1715629 <https://reviews.llvm.org/D52431#1715629>, @RKSimon wrote:

> @nemanjai Any luck on this? It seems to be something to do with PPCReduceCRLogicals::splitBlockOnBinaryCROp AllCRLogicalOps.push_back() calls, resulting in a reallocation and the original CRLogicalOpInfo &CRI reference being lost. Should/can the CRLogicalOpInfo& be passed by value instead?


Ah, this makes perfect sense. Thanks Simon. I'll try to put together a reproducer and a fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52431/new/

https://reviews.llvm.org/D52431





More information about the llvm-commits mailing list