[PATCH] D69116: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (1/2)

[Joan LLuch via Phabricator via llvm-commits]

joanlluch marked an inline comment as done.
joanlluch added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:3611-3612
     if ((Cond == ISD::SETEQ || Cond == ISD::SETNE) &&
         (VT == N0.getValueType() ||
          (isTypeLegal(VT) && VT.bitsLE(N0.getValueType()))) &&
         N0.getOpcode() == ISD::AND) {
----------------
spatel wrote:
> Within this block alone, we call N0.getValueType() at least 6 times. Better to make that a local variable like:
>   EVT N0VT = N0.getValueType();
Totally agree!,  but I was a bit shy of touching code made by others. 
Will do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69116/new/

https://reviews.llvm.org/D69116