[PATCH] D69107: [ThinLTO] Don't internalize during promotion

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.



In D69107#1714175 <https://reviews.llvm.org/D69107#1714175>, @evgeny777 wrote:

> From https://llvm.org/docs/LangRef.html#comdats :
>
>   Comdats have a name which represents the COMDAT key. All global objects that specify this key will only end up in the final object file if the linker chooses that key over some other key
>
>
> To enforce this LLVM `internalize` pass doesn't internalize entire COMDAT group if any of its members should be preserved (see `shouldPreserveGV`). At the moment we can internalize global
>  in `llvm::thinLTOResolvePrevailingInModule` without looking at other COMDAT group members and break this guarantee


Can you add a testcase which represents the situation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69107/new/

https://reviews.llvm.org/D69107