[PATCH] D69107: [ThinLTO] Don't internalize during promotion

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a comment.

>From https://llvm.org/docs/LangRef.html#comdats :

  Comdats have a name which represents the COMDAT key. All global objects that specify this key will only end up in the final object file if the linker chooses that key over some other key

To enforce this LLVM `internalize` pass doesn't internalize entire COMDAT group if any of its members should be preserved (see `shouldPreserveGV`). At the moment we can internalize global
in `llvm::thinLTOResolvePrevailingInModule` without looking at other COMDAT group members and break this guarantee


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69107/new/

https://reviews.llvm.org/D69107