[PATCH] D69097: [AArch64][MachineOutliner] Return address signing for outlined functions

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added a comment.

> So, if a, b and c participate in outlining, a and b have sign-return-address=all and c has sign-return-address=non-leaf, the new outlined function should behave like having sign-return-address=non-leaf? Or should we only allow outlining if the attributes match?

I think for safety we should always pick the strongest attribute from the existing functions, so that case should get `sign-return-address=all`. Alternatively, we could consider functions with different return address signing attributes to be incompatible, and outline `a` and `b` separately from `c`. I'm not too worried about optimal code generation when mixing attributes, as I expect them to match in almost all real-world use cases (they are set by command-line options, which will probably be consistent across the whole program).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69097/new/

https://reviews.llvm.org/D69097