[PATCH] D69098: Remove -DLLVM_USE_LINKER from Windows self host bots

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 04:11:05 PDT 2019


russell.gallop created this revision.
russell.gallop added a reviewer: rnk.
Herald added a project: LLVM.

As discussed in https://reviews.llvm.org/D69030, removing LLVM_USE_LINKER from bots which use that AND setting CMAKE_LINKER.


Repository:
  rL LLVM

https://reviews.llvm.org/D69098

Files:
  zorg/buildbot/builders/annotated/clang-windows.py
  zorg/buildbot/builders/annotated/sanitizer-windows.py


Index: zorg/buildbot/builders/annotated/sanitizer-windows.py
===================================================================
--- zorg/buildbot/builders/annotated/sanitizer-windows.py
+++ zorg/buildbot/builders/annotated/sanitizer-windows.py
@@ -34,15 +34,12 @@

     projects = ['llvm', 'clang', 'lld', 'compiler-rt']
     stages = 1
-    stage1_extra_cmake_args = [
+    extra_cmake_args = [
         '-DCMAKE_BUILD_TYPE=Release',
         '-DLLVM_ENABLE_PDB=ON',
         '-DLLVM_ENABLE_ASSERTIONS=ON',
         '-DLLVM_TARGETS_TO_BUILD=X86',
     ]
-    extra_cmake_args = stage1_extra_cmake_args + [
-        '-DLLVM_USE_LINKER=lld',
-    ]
     check_targets = ['check-asan', 'check-asan-dynamic', 'check-sanitizer',
                      'check-ubsan', 'check-fuzzer', 'check-cfi',
                      'check-profile', 'check-builtins']
@@ -56,7 +53,6 @@
     builder.run_steps(stages=stages,
                       projects=projects,
                       extra_cmake_args=extra_cmake_args,
-                      stage1_extra_cmake_args=stage1_extra_cmake_args,
                       check_targets=check_targets,
                       compiler=compiler,
                       linker=linker,
Index: zorg/buildbot/builders/annotated/clang-windows.py
===================================================================
--- zorg/buildbot/builders/annotated/clang-windows.py
+++ zorg/buildbot/builders/annotated/clang-windows.py
@@ -10,15 +10,12 @@

     projects = ['llvm', 'clang', 'lld', 'debuginfo-tests']
     stages = 2
-    stage1_extra_cmake_args = [
+    extra_cmake_args = [
         '-DCMAKE_BUILD_TYPE=Release',
         '-DLLVM_ENABLE_PDB=ON',
         '-DLLVM_ENABLE_ASSERTIONS=ON',
         '-DLLVM_TARGETS_TO_BUILD=all',
     ]
-    extra_cmake_args = stage1_extra_cmake_args + [
-        '-DLLVM_USE_LINKER=lld',
-    ]
     check_targets = ['check-llvm', 'check-clang', 'check-lld', 'check-debuginfo']

     # Check both stage 1 and stage 2.
@@ -31,7 +28,6 @@
     builder.run_steps(projects=projects,
                       stages=stages,
                       extra_cmake_args=extra_cmake_args,
-                      stage1_extra_cmake_args=stage1_extra_cmake_args,
                       check_targets=check_targets,
                       check_stages=check_stages,
                       compiler=compiler,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69098.225393.patch
Type: text/x-patch
Size: 2345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191017/75584364/attachment.bin>


More information about the llvm-commits mailing list