[PATCH] D68935: [LLD] [COFF] Wrap file location pair<StringRef,int> in Optional<>. NFC.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 14 11:11:53 PDT 2019
mstorsjo marked an inline comment as done.
mstorsjo added inline comments.
================
Comment at: lld/COFF/PDB.cpp:1818
exitOnErr(getFileName(cVStrTab, checksums, *nameIndex));
- return {filename, *lineNumber};
+ return std::pair<StringRef, uint32_t>{filename, *lineNumber};
}
----------------
MaskRay wrote:
> `return {{filename, *lineNumber}};` works (but I am not sure whether others like it)
Ah, that looks totally fine to me, and is nicely compact. `std::make_pair()` works as well, allowing omitting the template parameters.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68935/new/
https://reviews.llvm.org/D68935
More information about the llvm-commits
mailing list