[PATCH] D68935: [LLD] [COFF] Wrap file location pair<StringRef,int> in Optional<>. NFC.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I am in favor of this change. It makes the error case clearer.



================
Comment at: lld/COFF/PDB.cpp:1818
             exitOnErr(getFileName(cVStrTab, checksums, *nameIndex));
-        return {filename, *lineNumber};
+        return std::pair<StringRef, uint32_t>{filename, *lineNumber};
       }
----------------
`return {{filename, *lineNumber}};` works (but I am not sure whether others like it)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68935/new/

https://reviews.llvm.org/D68935