[PATCH] D68828: [AMDGPU] Allow DPP combiner to work with REG_SEQUENCE

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 15:30:40 PDT 2019


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp:420
   SmallVector<MachineInstr*, 4> OrigMIs, DPPMIs;
+  SmallSetVector<MachineInstr*, 4> RegSeqs;
   auto CombOldVGPR = getRegSubRegPair(*OldOpnd);
----------------
arsenm wrote:
> Why is this a SetVector?
I will try to add if several times, for each subreg. Thus set. I guess it can be just SmallSet though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68828/new/

https://reviews.llvm.org/D68828





More information about the llvm-commits mailing list