[PATCH] D29011: [IR] Add Freeze instruction

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 12 11:31:33 PDT 2019


lebedev.ri added a comment.

In D29011#1707274 <https://reviews.llvm.org/D29011#1707274>, @jdoerfert wrote:

> Two minor comments from my side.


Looks good to me with those two fixed.
Should you add `llvm::Freze` here by inheriting from `UnaryOperator` to make `isa<Freze>(Op)` possible?

> (I would like someone to include the keyword in the editor lists `llvm/utils/{emacs,vim}` after this landed)

There is also `llvm/utils/{kate}`.



================
Comment at: include/llvm/Bitcode/LLVMBitCodes.h:394
 enum UnaryOpcodes {
-  UNOP_NEG = 0
+  UNOP_NEG = 0,
+  UNOP_FREEZE = 1
----------------
I think you want to rebase.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29011/new/

https://reviews.llvm.org/D29011





More information about the llvm-commits mailing list