[PATCH] D29011: [IR] Add Freeze instruction

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Two minor comments from my side.

(I would like someone to include the keyword in the editor lists `llvm/utils/{emacs,vim}` after this landed)



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:671
   void visitFNeg(const User &I) { visitUnary(I, ISD::FNEG); }
+  void visitFreeze(const User &I);
 
----------------
The lady of the lake says this should be:
  `void visitFreeze(const User &I) { visitUnary(I, ISD::FREEZE); }`
If you have reason not to do it this way, also replace `visitUnrary` with `visitFNeg`, though I'd prefer not to.


================
Comment at: test/Bindings/llvm-c/freeze.ll:12
+  %6 = freeze <2 x float> %arg4
+  %7 = freeze i8* %arg5
+  ret i32 %1
----------------
Missing types, here and elsewhere I think:
- array
- struct w/ definition
- struct w/o definition (opaque)
- non-standard integer size (i666)

Missing inputs:
- undef
- null



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29011/new/

https://reviews.llvm.org/D29011