[PATCH] D68744: [GSYM] Add GsymCreator and GsymReader.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 08:59:19 PDT 2019


clayborg updated this revision to Diff 224372.
clayborg added a comment.

- Added full header documentation for GsymReader and GsymCreator.
- Cleaned up and removed some function that were not used and seemed like they would be used for iteration
- Made some GsymReader functions private and now with header doc intent of use should be clear
- Renamed a few functions to better names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68744/new/

https://reviews.llvm.org/D68744

Files:
  include/llvm/DebugInfo/GSYM/FileWriter.h
  include/llvm/DebugInfo/GSYM/GsymCreator.h
  include/llvm/DebugInfo/GSYM/GsymReader.h
  include/llvm/DebugInfo/GSYM/Header.h
  lib/DebugInfo/GSYM/CMakeLists.txt
  lib/DebugInfo/GSYM/FunctionInfo.cpp
  lib/DebugInfo/GSYM/GsymCreator.cpp
  lib/DebugInfo/GSYM/GsymReader.cpp
  lib/DebugInfo/GSYM/Header.cpp
  unittests/DebugInfo/GSYM/CMakeLists.txt
  unittests/DebugInfo/GSYM/GSYMTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68744.224372.patch
Type: text/x-patch
Size: 57159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191010/f067d004/attachment.bin>


More information about the llvm-commits mailing list