[PATCH] D68744: [GSYM] Add GsymCreator and GsymReader.

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked an inline comment as done.
clayborg added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/GsymCreator.h:140
+  std::vector<llvm::gsym::FileEntry> Files;
+  std::vector<uint8_t> UUID;
+  bool Finalized = false;
----------------
aprantl wrote:
> In other places we use `uint8_t UUID[16]` for this.
The users set the UUID with the setUUID function which takes an array ref and it currently copies all bytes. I could switch this to "uint8_t UUID[GSYM_MAX_UUID_SIZE];" and switch the error checking to be done on the call to setUUID. Right now the error handling happens when you try to encode. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68744/new/

https://reviews.llvm.org/D68744