[PATCH] D68680: [dsymutil] Fix handling of common symbols in multiple object files.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/MachODebugMapParser.cpp:144
+      // The symbol is already present.
+      continue;
+    }
----------------
This looks like  no-op. I guess we could just ignore the return value?


================
Comment at: llvm/tools/dsymutil/MachODebugMapParser.cpp:498
       CurrentObjectAddresses[*Name] = None;
-    else
+    } else if (Flags & SymbolRef::SF_Common) {
+      CurrentObjectAddresses[*Name] = None;
----------------
is it expected that a symbol with `SymbolRef::SF_Absolute | SymbolRef::SF_Common` goes into the first if only?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68680/new/

https://reviews.llvm.org/D68680