[PATCH] D51018: [sancov] Accommodate sancov and coverage report server for use under Windows

[Douglas Gliner via Phabricator via llvm-commits]

dgg5503 updated this revision to Diff 223973.
dgg5503 retitled this revision from "[sancov] Fixed malformed JSON when symbolizing coverage information" to "[sancov] Accommodate sancov and coverage report server for use under Windows".
dgg5503 edited the summary of this revision.
dgg5503 added a comment.

@vsk thanks for the review! It looks like the JSON support library implements what `JSONWriter` does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51018/new/

https://reviews.llvm.org/D51018

Files:
  llvm/test/tools/sancov/blacklist.test
  llvm/test/tools/sancov/covered_functions.test
  llvm/test/tools/sancov/merge.test
  llvm/test/tools/sancov/not_covered_functions.test
  llvm/test/tools/sancov/print.test
  llvm/test/tools/sancov/stats.test
  llvm/test/tools/sancov/symbolize.test
  llvm/test/tools/sancov/symbolize_noskip_dead_files.test
  llvm/test/tools/sancov/validation.test
  llvm/tools/sancov/coverage-report-server.py
  llvm/tools/sancov/sancov.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51018.223973.patch
Type: text/x-patch
Size: 19497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191009/d2b03941/attachment.bin>