[PATCH] D68598: [IA] Recognize hexadecimal escape sequences

Bill Wendling via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 15:03:59 PDT 2019


Done: r374124.

On Tue, Oct 8, 2019 at 12:01 AM Jian Cai via Phabricator <
reviews at reviews.llvm.org> wrote:

> jcai19 added inline comments.
>
>
> ================
> Comment at: llvm/test/MC/AsmParser/directive_ascii.s:46
> +TEST7:
> +        .ascii "\x64\Xa6B"
> ----------------
> Thanks for the update. Could we have one more test case with last eight
> bits within the range of 7f and ff, and maybe with lower-case letter, e.g.
> \x8a?
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D68598/new/
>
> https://reviews.llvm.org/D68598
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191008/59ad4645/attachment.html>


More information about the llvm-commits mailing list