<div dir="ltr">Done: r374124.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 8, 2019 at 12:01 AM Jian Cai via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">jcai19 added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/test/MC/AsmParser/directive_ascii.s:46<br>
+TEST7:<br>
+        .ascii "\x64\Xa6B"<br>
----------------<br>
Thanks for the update. Could we have one more test case with last eight bits within the range of 7f and ff, and maybe with lower-case letter, e.g. \x8a?<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D68598/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68598/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D68598" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68598</a><br>
<br>
<br>
<br>
</blockquote></div>