[PATCH] D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 10:26:52 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:826
+    // Change the opcode to ADDIS8.  If the global address is the address of
+    // an external symbol, is a jump table address, is a block address; or if
+    // large code model is enabled then generate a TOC entry and reference that.
----------------
sfertile wrote:
> Was the ';' after 'block-address' meant to be a comma?
Add "or" before "is a block address".
Add "the" before "large code model".
Add a comma after "Otherwise".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68341/new/

https://reviews.llvm.org/D68341





More information about the llvm-commits mailing list