[PATCH] D67968: [TableGen] Introduce a generic automaton (DFA) backend

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 08:13:31 PDT 2019


Wow, that's a really nice builder!

I think I see what's going on; I'm using std::next() eagerly to attempt to
get a correct iterator that isn't invalidated during the loop. But if that
actually ends up being Heads.end(), that *will* be invalidated during
push_back.

I'll fix forward if that's OK?

James

On Fri, 4 Oct 2019 at 16:02, Simon Pilgrim via Phabricator <
reviews at reviews.llvm.org> wrote:

> RKSimon added a comment.
>
> @jmolloy This is causing an assertion in EXPENSIVE_CHECKS builds - please
> can you take a look?
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/20007/steps/test-check-all/logs/stdio
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67968/new/
>
> https://reviews.llvm.org/D67968
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191004/a3a60583/attachment.html>


More information about the llvm-commits mailing list