<div dir="ltr">Wow, that's a really nice builder!<div><br></div><div>I think I see what's going on; I'm using std::next() eagerly to attempt to get a correct iterator that isn't invalidated during the loop. But if that actually ends up being Heads.end(), that *will* be invalidated during push_back.</div><div><br></div><div>I'll fix forward if that's OK?</div><div><br></div><div>James</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 4 Oct 2019 at 16:02, Simon Pilgrim via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">RKSimon added a comment.<br>
<br>
@jmolloy This is causing an assertion in EXPENSIVE_CHECKS builds - please can you take a look?<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/20007/steps/test-check-all/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/20007/steps/test-check-all/logs/stdio</a><br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D67968/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67968/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D67968" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67968</a><br>
<br>
<br>
<br>
</blockquote></div>